Fix SYSTEC error lookup for ctypes result codes - #2095
Open
timothyanderson096-ocdealcheck wants to merge 2 commits into
Open
Fix SYSTEC error lookup for ctypes result codes#2095timothyanderson096-ocdealcheck wants to merge 2 commits into
timothyanderson096-ocdealcheck wants to merge 2 commits into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize SYSTEC
ctypesreturn codes through.valuebefore looking them up in the error-message mapping.UcanExceptioncurrently uses thectypes.c_ubyteresult object itself as a dictionary key.ctypesscalar values are unhashable, so error handling can raiseTypeError: unhashable typeand hide the original CAN error.This change:
result.valueerror_codec_ubyteSYSTEC return code produces the underlying diagnostic instead of aTypeErrorFixes #2077.